-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge branch 'next' into 'dev-harmony' #2577
Conversation
Walkthrough此次更改涉及多个组件的改进,包括 Changes
Possibly related issues
Possibly related PRs
Poem
Tip New features:
Notes:
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Files skipped from review as they are similar to previous changes (2)
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
const [list] = useState([1, 2, 3, 4, 5, 6, 7]) | ||
const [show, SetShow] = useState(false) | ||
const [toastMsg, SetToastMsg] = useState('') | ||
const toastShow = (msg: any) => { | ||
SetToastMsg(msg) | ||
SetShow(true) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议修改状态设置函数的命名并验证事件处理逻辑。
状态设置函数 SetShow
和 SetToastMsg
应遵循驼峰命名规则,建议改为 setShow
和 setToastMsg
。同时,请确认事件处理逻辑符合 React 最佳实践。
Also applies to: 19-47
if (beforeUpload) { | ||
beforeUpload(new Array<File>().slice.call(_files)).then( | ||
(f: Array<File> | boolean) => { | ||
const _files: File[] = filterFiles(new Array<File>().slice.call(f)) | ||
if (!_files.length) res.tempFiles = [] | ||
readFile(_files) | ||
} | ||
) | ||
} else { | ||
readFile(_files) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
集成 beforeUpload
函数
beforeUpload
函数已被成功集成到 InternalUploader
组件中,允许在上传过程前执行自定义逻辑。请确保添加相应的单元测试来验证这一新功能的正确实现。
是否需要我帮助编写单元测试代码或在GitHub上跟踪此任务?
Also applies to: 489-499
🤔 这个变动的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
clickable
属性到Cell
组件,提供点击样式反馈。beforeUpload
函数,允许在文件上传前进行自定义逻辑处理。PullToRefresh
组件,支持根据平台条件渲染内容。Dialog
组件交互功能,提升弹窗组件的用户体验。错误修复
Uploader
组件的文件上传逻辑,确保在上传前正确处理文件。Sticky
组件的样式更新逻辑,确保在属性变化时及时更新。文档
clickable
和beforeUpload
属性的描述,提升开发者使用体验。