Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cell): add clickable prop to support click style feedback #2527

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

Alex-huxiyang
Copy link
Collaborator

@Alex-huxiyang Alex-huxiyang commented Aug 6, 2024

🤔 这个变动的性质是?

  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进

Summary by CodeRabbit

  • 新功能
    • 添加了clickable属性,允许用户指定单元格是否可点击,默认值为false
    • 改进了单元格组件的样式,以增强交互效果,包括新的悬停和点击状态样式。
  • 文档
    • 在组件文档中添加了clickable属性的说明,详细描述了其功能和默认值。

Copy link

coderabbitai bot commented Aug 6, 2024

Walkthrough

本次更改主要在于增强了单元格组件的交互性,新增了clickable属性,以便能够动态指示单元格是否可点击。此外,还改进了样式,添加了悬停和点击时的视觉反馈,提升了用户体验。整体上,这些变化为开发者提供了更多的灵活性与更好的用户交互效果。

Changes

文件路径 更改摘要
src/packages/cell/cell.scss 增加了交互状态和悬停效果的样式,新增&-clickable类修饰符。
src/packages/cell/cell.taro.tsx CellProps接口中新增clickable属性,默认值为false
src/packages/cell/cell.tsx CellProps接口中新增clickable属性,默认值为false
src/packages/cell/demos/h5/demo1.tsx Demo1组件中为Cell新增clickable属性。
src/packages/cell/demos/taro/demo1.tsx Demo1组件中为Cell新增clickable属性。
src/packages/cell/doc.en-US.md 新增clickable属性的文档说明,默认为false
src/packages/cell/doc.md 新增clickable属性的文档说明,默认为false
src/packages/cell/doc.taro.md 新增clickable属性的文档说明,默认为false
src/packages/cell/doc.zh-TW.md 新增clickable属性的文档说明,默认为false

Poem

🐰 在单元格里跳跃欢快,
新增功能真精彩,
点击反馈乐无穷,
用户体验更轻松。
让我们一同欢庆,
交互新风貌来临! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Alex-huxiyang Alex-huxiyang linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.18%. Comparing base (25dd468) to head (3f7d32b).
Report is 6 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2527   +/-   ##
=======================================
  Coverage   83.17%   83.18%           
=======================================
  Files         217      217           
  Lines       17799    17801    +2     
  Branches     2570     2571    +1     
=======================================
+ Hits        14805    14807    +2     
  Misses       2989     2989           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oasis-cloud oasis-cloud merged commit 3364ee6 into jdf2e:next Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react版本cell为什么没有点击后样式反馈功能
2 participants