Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Within iframes, content script should defer action to the top-level window #61

Open
jchang504 opened this issue Nov 26, 2017 · 0 comments

Comments

@jchang504
Copy link
Owner

A quick, manifest-only change enabled the content script to be injected into iframes, including dynamically generated ones (fixing #25). But it's not a complete solution, because now the UI runs within the iframe, which looks particularly weird with small windows like on hangouts.google.com. The only case where it's a more than cosmetic problem is tab search, where the results can be obscured within a small window. I think it's still rather an edge case, and the work-to-UX-gains ratio is high.

To fix it, we can follow an approach like in https://stackoverflow.com/a/12904047, which is where I started for the solution to #25.

jchang504 added a commit that referenced this issue Nov 26, 2017
Simple 2-line manifest change, though it's not a complete solution (see #61).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant