Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys aren't captured within iframes #25

Closed
jchang504 opened this issue Apr 10, 2017 · 2 comments
Closed

Hotkeys aren't captured within iframes #25

jchang504 opened this issue Apr 10, 2017 · 2 comments

Comments

@jchang504
Copy link
Owner

Hotkeys work on the rest of the page, but not when focused on the editing window. This initially looked like #2, but I don't see the same console messages about sandboxing. There are some messages about scripts being blocked on a slow connection, but I don't see the confirmation message it mentions, I'm not on a slow connection so there's no reason for our content script to be blocked, and I don't see any mention of KeepTabs (it seems related to ads scripts). Logs are attached:
www.yamli.com-1491788063736.txt

@jchang504 jchang504 self-assigned this Apr 10, 2017
@jchang504
Copy link
Owner Author

Also noted within text box of a follow-up on Piazza. Nothing comes out in the logs (normal behavior when focused on the page outside of the editing box).

@jchang504 jchang504 changed the title Hotkeys aren't captured within editing window of Yamli (+ possibly other sites with similar structures?) Hotkeys aren't captured within iframes Sep 16, 2017
@jchang504
Copy link
Owner Author

Observed this in https://hangouts.google.com as well within chat windows. I'm pretty sure it's because they're iframes. Looks like there may be a simple solution, though I'm not sure if this handles dynamically generated (e.g. chat boxes) iframes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant