Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys don't work within editing window of a Google Doc #2

Closed
jchang504 opened this issue Apr 4, 2017 · 2 comments
Closed

Hotkeys don't work within editing window of a Google Doc #2

jchang504 opened this issue Apr 4, 2017 · 2 comments
Assignees
Labels

Comments

@jchang504
Copy link
Owner

KeepTabs hotkeys don't work when the focus is within the editable part of a Google Docs page (they do if you click outside of it). The console reports this:

include.preload.js:341 Blocked script execution in 'about:blank' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.

Not sure if we can actually fix this. Putting the key event handlers on window instead of document might work.

@jchang504
Copy link
Owner Author

Yeah, looks like this can't be fixed due to the sandboxing. Moving the key event handlers to window (c975045) didn't work.

@jchang504
Copy link
Owner Author

Turns out this was actually fixed by 1f92deb, so my initial conclusion was obviously wrong. Interestingly though, the UI does not show up when activating hotkeys within the editing window. I've opened #62 for this.

@jchang504 jchang504 added bug and removed WAI labels Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant