Skip to content

Commit

Permalink
Remove percy based visual regression tests (elastic#136359)
Browse files Browse the repository at this point in the history
* Remove percy based visual regression tests

These have been disabled for ~3 years, the agent is deprecated, and our
snapshot environment is inactive.

* [CI] Auto-commit changed files from 'yarn kbn run build -i @kbn/pm'

* update codeowners

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
jbudz and kibanamachine authored Jul 14, 2022
1 parent 4e043fb commit a91aeb4
Show file tree
Hide file tree
Showing 29 changed files with 66 additions and 1,428 deletions.
2 changes: 0 additions & 2 deletions .buildkite/ftr_configs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ disabled:
- x-pack/plugins/observability/e2e/synthetics_run.ts

# Configs that exist but weren't running in CI when this file was introduced
- test/visual_regression/config.ts
- x-pack/test/visual_regression/config.ts
- x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/actions/config.ts
- x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/telemetry/config.ts
- x-pack/test/alerting_api_integration/spaces_only_legacy/config.ts
Expand Down
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,6 @@ module.exports = {
'test/*/config_open.ts',
'test/*/*.config.ts',
'test/*/{tests,test_suites,apis,apps}/**/*',
'test/visual_regression/tests/**/*',
'x-pack/test/*/{tests,test_suites,apis,apps}/**/*',
'x-pack/test/*/*config.*ts',
'x-pack/test/saved_object_api_integration/*/apis/**/*',
Expand Down
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@
/x-pack/test/api_integration/apis/maps/ @elastic/kibana-gis
/x-pack/test/functional/apps/maps/ @elastic/kibana-gis
/x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis
/x-pack/test/visual_regression/tests/maps/index.js @elastic/kibana-gis
/x-pack/plugins/stack_alerts/server/alert_types/geo_containment @elastic/kibana-gis
/x-pack/plugins/stack_alerts/public/alert_types/geo_containment @elastic/kibana-gis
#CC# /x-pack/plugins/file_upload @elastic/kibana-gis
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,6 @@
"@mapbox/vector-tile": "1.3.1",
"@octokit/rest": "^16.35.0",
"@openpgp/web-stream-tools": "^0.0.10",
"@percy/agent": "^0.28.6",
"@storybook/addon-a11y": "^6.4.22",
"@storybook/addon-actions": "^6.4.22",
"@storybook/addon-controls": "^6.4.22",
Expand Down
88 changes: 44 additions & 44 deletions packages/kbn-pm/dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23844,7 +23844,7 @@ module.exports.sync = (patterns, {force, dryRun, cwd = process.cwd(), ...options

"use strict";

const indentString = __webpack_require__("../../node_modules/del/node_modules/indent-string/index.js");
const indentString = __webpack_require__("../../node_modules/indent-string/index.js");
const cleanStack = __webpack_require__("../../node_modules/clean-stack/index.js");

const cleanInternalStack = stack => stack.replace(/\s+at .*aggregate-error\/index.js:\d+:\d+\)?/g, '');
Expand Down Expand Up @@ -24257,49 +24257,6 @@ module.exports = {
};


/***/ }),

/***/ "../../node_modules/del/node_modules/indent-string/index.js":
/***/ (function(module, exports, __webpack_require__) {

"use strict";


module.exports = (string, count = 1, options) => {
options = {
indent: ' ',
includeEmptyLines: false,
...options
};

if (typeof string !== 'string') {
throw new TypeError(
`Expected \`input\` to be a \`string\`, got \`${typeof string}\``
);
}

if (typeof count !== 'number') {
throw new TypeError(
`Expected \`count\` to be a \`number\`, got \`${typeof count}\``
);
}

if (typeof options.indent !== 'string') {
throw new TypeError(
`Expected \`options.indent\` to be a \`string\`, got \`${typeof options.indent}\``
);
}

if (count === 0) {
return string;
}

const regex = options.includeEmptyLines ? /^/gm : /^(?!\s*$)/gm;

return string.replace(regex, options.indent.repeat(count));
};


/***/ }),

/***/ "../../node_modules/del/node_modules/p-map/index.js":
Expand Down Expand Up @@ -34349,6 +34306,49 @@ if (
}());


/***/ }),

/***/ "../../node_modules/indent-string/index.js":
/***/ (function(module, exports, __webpack_require__) {

"use strict";


module.exports = (string, count = 1, options) => {
options = {
indent: ' ',
includeEmptyLines: false,
...options
};

if (typeof string !== 'string') {
throw new TypeError(
`Expected \`input\` to be a \`string\`, got \`${typeof string}\``
);
}

if (typeof count !== 'number') {
throw new TypeError(
`Expected \`count\` to be a \`number\`, got \`${typeof count}\``
);
}

if (typeof options.indent !== 'string') {
throw new TypeError(
`Expected \`options.indent\` to be a \`string\`, got \`${typeof options.indent}\``
);
}

if (count === 0) {
return string;
}

const regex = options.includeEmptyLines ? /^/gm : /^(?!\s*$)/gm;

return string.replace(regex, options.indent.repeat(count));
};


/***/ }),

/***/ "../../node_modules/inflight/inflight.js":
Expand Down
30 changes: 0 additions & 30 deletions test/visual_regression/config.ts

This file was deleted.

15 changes: 0 additions & 15 deletions test/visual_regression/ftr_provider_context.ts

This file was deleted.

15 changes: 0 additions & 15 deletions test/visual_regression/services/index.ts

This file was deleted.

9 changes: 0 additions & 9 deletions test/visual_regression/services/visual_testing/index.ts

This file was deleted.

102 changes: 0 additions & 102 deletions test/visual_regression/services/visual_testing/take_percy_snapshot.js

This file was deleted.

Loading

0 comments on commit a91aeb4

Please sign in to comment.