Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove percy based visual regression tests #136359

Merged
merged 5 commits into from
Jul 14, 2022
Merged

Remove percy based visual regression tests #136359

merged 5 commits into from
Jul 14, 2022

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jul 14, 2022 •
edited
Loading

These have been disabled for ~3 years, the agent is deprecated, and our
snapshot environment is inactive.

  • Update codeowners (after teams have been pinged)

@jbudz
Remove percy based visual regression tests
e9c1fef 
These have been disabled for ~3 years, the agent is deprecated, and our
snapshot environment is inactive.
@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:auto-version labels Jul 14, 2022
@jbudz jbudz marked this pull request as ready for review July 14, 2022 03:23
@jbudz jbudz requested review from a team as code owners July 14, 2022 03:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

nreese
nreese approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM
code review

@jbudz jbudz enabled auto-merge (squash) July 14, 2022 15:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit a91aeb4 into elastic:main Jul 14, 2022
@kibanamachine kibanamachine added v8.4.0 backport:skip This commit does not require backporting labels Jul 14, 2022
@liza-mae
Copy link
Contributor

This was still running parting of release CI and I was not included in this review.

jbudz added a commit to jbudz/kibana that referenced this pull request Jul 14, 2022
@jbudz
Revert "Remove percy based visual regression tests (elastic#136359)"
9c3466e 
This reverts commit a91aeb4.
@jbudz
Copy link
Member Author

jbudz commented Jul 14, 2022

Revert in progress - #136437.

jbudz added a commit that referenced this pull request Jul 14, 2022
@jbudz
Revert "Remove percy based visual regression tests (#136359)" (#136437)
33b743c 
* Revert "Remove percy based visual regression tests (#136359)"

This reverts commit a91aeb4.

* update codeowners
@tylersmalley tylersmalley mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@spalger spalger spalger approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jbudz @elasticmachine @kibana-ci @liza-mae @nreese @spalger @kibanamachine