Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index error #279

Closed
wants to merge 3 commits into from
Closed

Fix index error #279

wants to merge 3 commits into from

Conversation

drppi44
Copy link
Contributor

@drppi44 drppi44 commented Apr 25, 2018

Sometimes this line raise indexerror
i didn't research this case

@avelis avelis requested a review from albertyw April 25, 2018 19:16
Copy link
Member

@albertyw albertyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to not use a try/except unless it's really needed. If there's an IndexError here, then that means len(requests) < target_count - 1. I'll make a separate PR to use an if statement to handle that case, and to make the later delete() still work.

@albertyw
Copy link
Member

albertyw commented May 2, 2018

This has been superseded by #280.

@albertyw albertyw closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants