Fix garbage collection logic for small tables #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelis
reviewed
Apr 30, 2018
silk/models.py
Outdated
| @@ -148,6 +148,8 @@ def garbage_collect(cls, force=False): | |||
| requests = cls.objects.order_by('-start_time') | |||
| if not requests: | |||
| return | |||
| if len(requests)-1 < target_count: | |||
There was a problem hiding this comment.
Couldn't we combine this line with the line above on 149? I know it lengthens the if check with an or but ensures only one return statement.
|
@avelis I made that update. |
|
@albertyw Thanks! |
Closed
|
thatnks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that there will be no
IndexErrorswhen calling thegarbage_collectmethod. I'm guessing this may be possible if there are fewerRequests than the target number of requests.cc @avelis @drppi44
Replaces #279