Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't crash when a route is 404 #129

Merged
merged 1 commit into from
Jul 13, 2016

Commits on Jul 13, 2016

  1. don't crash when a route is 404

    multiple issues:
     * resolve() might throw, handle that case
     * unhandled exception in `process_request` leads to last successful
       `request_model` remain in `DataCollector` and being used to create
       a response model for the current failed request, leading to
       a constraint violation thrown by the db (creating another response
       for the previously succesful request)
    
    resolution
     * handle 404 by saving NULL/None as view name
     * clean out `DataCollector` state when starting a request, before doing
       anything.
    chrono committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    1b5fb2c View commit details
    Browse the repository at this point in the history