don't crash when a route is 404 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiple issues: * resolve() might throw, handle that case * unhandled exception in `process_request` leads to last successful `request_model` remain in `DataCollector` and being used to create a response model for the current failed request, leading to a constraint violation thrown by the db (creating another response for the previously succesful request) resolution * handle 404 by saving NULL/None as view name * clean out `DataCollector` state when starting a request, before doing anything.
|
@chrono Thanks for the contribution and for addressing this. |
|
Hi, when is it planned to deploy this fix as a new version of silk? |
|
@Tosterr I will try to get to by EOD today. |
|
@avelis thanks for the response, since there is no new version I would like to ask if it is possible to do it before Friday EOB? |
|
@Tosterr I think I can do that. Sorry for the delays on release. |
|
@Tosterr I published 0.6.2 to PyPi. I also made a release for it on Github for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiple issues:
process_requestleads to last successfulrequest_modelremain inDataCollectorand being used to createa response model for the current failed request, leading to
a constraint violation thrown by the db (creating another response
for the previously succesful request)
resolution
DataCollectorstate when starting a request, before doinganything.