Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Fix kernel build #25320

Merged

Conversation

charleshofer
Copy link
Contributor

When we build the wheel that contains prebuilt GPU kernels, we want to check the directory for the hybrid file instead of the directory, which won't exist if you're only building the ROCm wheel.

Created from: ROCm#173

Copy link

google-cla bot commented Dec 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dfm dfm self-assigned this Dec 6, 2024
@google-ml-butler google-ml-butler bot added kokoro:force-run pull ready Ready for copybara import and testing labels Dec 9, 2024
@copybara-service copybara-service bot merged commit cc258f5 into jax-ml:main Dec 9, 2024
17 of 18 checks passed
@dfm
Copy link
Collaborator

dfm commented Dec 9, 2024

Thanks @charleshofer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull ready Ready for copybara import and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants