GH-9948: Fix kernel build #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleshofer
requested review from
mrodden,
JehandadKhan,
Ruturaj4 and
zahiqbal
|
This is prereq for #137 to work. I've merged it into that PR's branch, but I'm making this change separately so that we can push this upstream on its own. |
mrodden
approved these changes
Dec 5, 2024
charleshofer
added
the
open-upstream
|
Feature branch from main is ready. Create a new PR destined for upstream? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we build the wheel that contains prebuilt GPU kernels, we want to check the
/__main__/jaxlib/rocmdirectory for the hybrid file instead of the__main__/jaxlib/cudadirectory, which won't exist if you're only building the ROCm wheel.Story: https://github.com/ROCm/frameworks-internal/issues/9948