-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with upstream @ 7b761858 #1052
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in 8.3 (Shadow DOM)
Fix possible typos in 1.3.6 (Polyfills and transpilers)
Sync examples from 2 commits in 8.5 (Shadow DOM slots...)
Fix typo in 8.5 (Shadow DOM slots...)
Update article.md in section 2.8
2-ui / 2-events / 5-dispatch-events In subchapter "Event constructor": first word use "Built-in" instead of "Build-in"
Fix typo in 9.1 (Patterns and flags)
* Fix typos. * Update a support note. * Add a reference for a yet unexplained pattern.
Replace unicode with Unicode all over the book
`\bHello\b` pattern was just analyzed in the previous paragraph, so the current wording is a bit confusing.
Without the `g` flag, we cannot say that the price is skipped. Without the `\b` assertion, we will have the part of the price in the result.
As the task uses multiline HTML and the note at the end suggests using `s` flag, the lazy quantifier would be safer.
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10765 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=11021 Can be tested in the Goole Chrome Beta, Dev, and Canary branches now, as well as in the Node.js v8-canary branch.
in 06-advanced-functions/06-function-object/5-sum-many-brackets/solution.md
…s/04-throttle/solution.md Well there is still a chance for a race condition but a smaller one. We would need an atomic "if or set" for isThrottled
Add missing semicolon
avoid race condition in 06-advanced-functions/09-call-apply-decorator…
1 typo in 06-function-object
No polyfill needed any longer
link to deprecated v0
…c-await improve readability of article in chapter 8, async
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated to merge changes from en.javascript.info at 7b76185
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
Click to open a list of 128 files
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.info
git checkout master
git pull upstream master
git checkout --ours <path>
git diff --word-diff master...upstream/master <path>
(please note: three dots in the command)git push origin master
Please ignore changes in README.md (git checkout --ours README.md && git commit -m ignore README.md).
This PR will be closed and replaced with a new one in a few days.