Skip to content

Conversation

@louis-jan
Copy link
Contributor

Describe Your Changes

This PR improves the quick start UX by skipping model verification, which is always Jan V2. This will significantly reduce the time required to prepare the quick-start model.

Also removed HF Token for this as this is a public model.

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the quick start experience by skipping model verification for the Jan V2 model, which is a known public model that doesn't require validation. This change reduces the initial setup time by eliminating an unnecessary API call to fetch model metadata from HuggingFace.

Key Changes:

  • Added optional skipVerification parameter to pullModelWithMetadata method
  • Removed HuggingFace token requirement for quick start flow (not needed for public models)
  • Updated dependency arrays to reflect removed dependencies

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
web-app/src/services/models/types.ts Added optional skipVerification parameter to pullModelWithMetadata interface
web-app/src/services/models/default.ts Implemented logic to conditionally skip HuggingFace metadata fetching when skipVerification is true
web-app/src/containers/SetupScreen.tsx Removed unused useGeneralSetting import and hook, passed skipVerification: true for quick start download, cleaned up dependency arrays

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@louis-jan louis-jan merged commit 09fe4ce into release/v0.7.4 Dec 2, 2025
20 checks passed
@louis-jan louis-jan deleted the fix/skip-model-verification-on-quick-start branch December 2, 2025 05:29
@github-actions github-actions bot added this to the v0.7.6 milestone Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants