Skip to content

Commit 09fe4ce

Browse files
authored
fix: skip model verification on quick start (#7083)
1 parent f51ef54 commit 09fe4ce

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

web-app/src/containers/SetupScreen.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { PlatformFeatures } from '@/lib/platform/const'
1313
import { PlatformFeature } from '@/lib/platform'
1414
import { useDownloadStore } from '@/hooks/useDownloadStore'
1515
import { useServiceHub } from '@/hooks/useServiceHub'
16-
import { useGeneralSetting } from '@/hooks/useGeneralSetting'
1716
import { useEffect, useMemo, useCallback, useState, useRef } from 'react'
1817
import { Progress } from '@/components/ui/progress'
1918
import type { CatalogModel } from '@/services/models/types'
@@ -94,7 +93,6 @@ function SetupScreen() {
9493
const { downloads, localDownloadingModels, addLocalDownloadingModel } =
9594
useDownloadStore()
9695
const serviceHub = useServiceHub()
97-
const { huggingfaceToken } = useGeneralSetting()
9896
const llamaProvider = getProviderByName('llamacpp')
9997
const [quickStartInitiated, setQuickStartInitiated] = useState(false)
10098
const [janModelV2, setJanModelV2] = useState<CatalogModel | null>(null)
@@ -111,7 +109,7 @@ function SetupScreen() {
111109
try {
112110
const repo = await serviceHub
113111
.models()
114-
.fetchHuggingFaceRepo(JAN_MODEL_V2_HF_REPO, huggingfaceToken)
112+
.fetchHuggingFaceRepo(JAN_MODEL_V2_HF_REPO)
115113

116114
if (repo) {
117115
const catalogModel = serviceHub.models().convertHfRepoToCatalogModel(repo)
@@ -120,7 +118,7 @@ function SetupScreen() {
120118
} catch (error) {
121119
console.error('Error fetching Jan Model V2:', error)
122120
}
123-
}, [serviceHub, huggingfaceToken])
121+
}, [serviceHub])
124122

125123
// Check model support for variants when janModelV2 is available
126124
useEffect(() => {
@@ -298,14 +296,14 @@ function SetupScreen() {
298296
(e) => e.model_id.toLowerCase() === 'mmproj-f16'
299297
) || janModelV2.mmproj_models?.[0]
300298
)?.path,
301-
huggingfaceToken
299+
undefined, // No HF token needed for public model
300+
true // Skip verification for faster download
302301
)
303302
}, [
304303
defaultVariant,
305304
janModelV2,
306305
addLocalDownloadingModel,
307306
serviceHub,
308-
huggingfaceToken,
309307
])
310308

311309
useEffect(() => {

web-app/src/services/models/default.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@ export class DefaultModelsService implements ModelsService {
199199
id: string,
200200
modelPath: string,
201201
mmprojPath?: string,
202-
hfToken?: string
202+
hfToken?: string,
203+
skipVerification?: boolean
203204
): Promise<void> {
204205
let modelSha256: string | undefined
205206
let modelSize: number | undefined
@@ -212,7 +213,7 @@ export class DefaultModelsService implements ModelsService {
212213
/https:\/\/huggingface\.co\/([^/]+\/[^/]+)\/resolve\/main\/(.+)/
213214
)
214215

215-
if (modelUrlMatch) {
216+
if (modelUrlMatch && !skipVerification) {
216217
const [, repoId, modelFilename] = modelUrlMatch
217218

218219
try {

web-app/src/services/models/types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ export interface ModelsService {
113113
id: string,
114114
modelPath: string,
115115
mmprojPath?: string,
116-
hfToken?: string
116+
hfToken?: string,
117+
skipVerification?: boolean
117118
): Promise<void>
118119
abortDownload(id: string): Promise<void>
119120
deleteModel(id: string): Promise<void>

0 commit comments

Comments
 (0)