Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(taro-lnd-link-details): info tab for taro-lnd link #667

Merged
merged 3 commits into from
Feb 11, 2023
Merged

feat(taro-lnd-link-details): info tab for taro-lnd link #667

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0c141e
feat(taro-lnd-link-details): info tab for taro-lnd link
Feb 8, 2023
2a4436e
fix(taro-backend-link): review notes
Feb 9, 2023
50135cd
fix(caseing): tarobackend
Feb 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/designer/link/LinkDetails.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,6 @@ describe('LinkDetails component', () => {
it('should display message for Taro to Lnd connection', () => {
const properties = { type: 'lndbackend' };
const { getByText } = renderComponent('alice-taro', 'alice', properties);
expect(getByText('Taro Lnd Connection')).toBeInTheDocument();
expect(getByText('Taro Backend Connection')).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions src/components/designer/link/LinkDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import SyncButton from '../SyncButton';
import Backend from './Backend';
import Channel from './Channel';
import Peer from './Peer';
import TaroLnd from './TaroLnd';
import TaroBackend from './TaroBackend';

interface Props {
link: ILink;
Expand Down Expand Up @@ -54,7 +54,7 @@ const LinkDetails: React.FC<Props> = ({ link, network }) => {
const taroNode = taro.find(n => n.name === link.from.nodeId);
const lndNode = lightning.find(n => n.name === link.to.nodeId);
if (taroNode && lndNode) {
cmp = <TaroLnd from={taroNode} to={lndNode as LndNode} />;
cmp = <TaroBackend from={taroNode} to={lndNode as LndNode} />;
}
}

Expand Down
4 changes: 2 additions & 2 deletions ...components/designer/link/TaroLnd.spec.tsx → ...onents/designer/link/TaroBackend.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import React from 'react';
import { LndNode, Status } from 'shared/types';
import { getNetwork, renderWithProviders } from 'utils/tests';
import TaroLnd from './TaroLnd';
import TaroBackend from './TaroBackend';

describe('Taro Lnd Link Component', () => {
const renderComponent = () => {
const network = getNetwork(1, 'test network', Status.Stopped, 1);
const from = network.nodes.taro[0];
const to = network.nodes.lightning[0] as LndNode;
const result = renderWithProviders(<TaroLnd from={from} to={to} />);
const result = renderWithProviders(<TaroBackend from={from} to={to} />);
return {
...result,
from,
Expand Down
6 changes: 3 additions & 3 deletions src/components/designer/link/TaroLnd.tsx → src/components/designer/link/TaroBackend.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ interface Props {
to: LndNode;
}

const TaroLnd: React.FC<Props> = ({ from, to }) => {
const { l } = usePrefixedTranslation('cmps.designer.link.lndbackend');
const TaroBackend: React.FC<Props> = ({ from, to }) => {
const { l } = usePrefixedTranslation('cmps.designer.link.tarobackend');
jamaljsr marked this conversation as resolved.
Show resolved Hide resolved

const fromDetails: DetailValues = [
{ label: l('name'), value: from.name },
Expand Down Expand Up @@ -42,4 +42,4 @@ const TaroLnd: React.FC<Props> = ({ from, to }) => {
);
};

export default TaroLnd;
export default TaroBackend;
16 changes: 8 additions & 8 deletions src/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,14 +147,14 @@
"cmps.designer.link.Peer.implementation": "Implementation",
"cmps.designer.link.Peer.version": "Version",
"cmps.designer.link.Peer.status": "Status",
"cmps.designer.link.lndbackend.title": "Taro Lnd Connection",
"cmps.designer.link.lndbackend.desc": "Taro nodes communicate over lnd to mint and transfer assets.",
"cmps.designer.link.lndbackend.taroTitle": "Taro Node",
"cmps.designer.link.lndbackend.lndTitle": "Lnd Node",
"cmps.designer.link.lndbackend.name": "Name",
"cmps.designer.link.lndbackend.implementation": "Implementation",
"cmps.designer.link.lndbackend.version": "Version",
"cmps.designer.link.lndbackend.status": "Status",
"cmps.designer.link.tarobackend.title": "Taro Backend Connection",
"cmps.designer.link.tarobackend.desc": "Taro nodes communicate with lnd to mint and transfer assets.",
"cmps.designer.link.tarobackend.taroTitle": "Taro Node",
"cmps.designer.link.tarobackend.lndTitle": "LND Node",
"cmps.designer.link.tarobackend.name": "Name",
"cmps.designer.link.tarobackend.implementation": "Implementation",
"cmps.designer.link.tarobackend.version": "Version",
"cmps.designer.link.tarobackend.status": "Status",
"cmps.designer.lightning.actions.CreateInvoiceModal.title": "Create Lightning Invoice",
"cmps.designer.lightning.actions.CreateInvoiceModal.nodeLabel": "Node",
"cmps.designer.lightning.actions.CreateInvoiceModal.amountLabel": "Amount",
Expand Down