feat(taro-lnd-link-details): info tab for taro-lnd link #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added basic taro-lnd peer link info. Added test for taro-lnd link. Updated LinkDetails tests for taro nodes.
amovfx
commented
Feb 8, 2023
jamaljsr
reviewed
Feb 8, 2023
jamaljsr
reviewed
Feb 10, 2023
|
Is there an easy way to move this over to draft? I decided to add the change TaroBackend ability to this pr. Or should that be a separate pr? |
|
There is a "Convert to draft" link under the Reviewers section of this page. Definitely create a separate PR. These two features are unrelated, and this PR is pretty much done. |
|
Okay, thanks for the guidance. |
Proper casing on the usePrefixedTranslation
jamaljsr
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added basic taro-lnd peer link info.
Added test for taro-lnd link.
Updated LinkDetails tests for taro nodes.
Steps to Test