Fix #99

[nichoth]

This is a fix for #99. I had to add some dependencies and change the version of rollup-plugin-web-worker-loader in order to run the example locally. I documented the changes in the README though.

I made a change to the package.json style, in that I added dist to .gitignore, and !dist to .npmignore; I wasn't sure how you feel about committing compiled code.

[jakubfiala]

great fix, thank you! I'd just ask you not to remove the dist folder, and had one question about the dependency changes

[jakubfiala]

my reasoning for checking in the dist directory is that I want to let people quickly grab the minified library even if they don't want to use NPM. I'm aware there are now CDN services such as unpkg.com but they're still effectively NPM proxies. So I'd suggest keeping the dist folder checked in, if you don't mind.

[jakubfiala]

thanks! I don't think every library needs its own dev server setup, it's usually relatively pain-free to start a static HTML server in the demo directory and just have npm run watch refreshing the bundle. But I guess it's worth making it a little simpler for Atrament contributors.

[jakubfiala]

hmm, I'm a little concerned about downgrading rollup by 2 major versions. Do you know why you've had to do this?

[nichoth]

Yes, npm install failed for me unless I downgraded the version. This is the message:

atrament issue-99 % npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: rollup-plugin-web-worker-loader@1.6.1
npm ERR! Found: rollup@4.17.2
npm ERR! node_modules/rollup
npm ERR!   rollup@"^4.9.4" from the root project
npm ERR!   peerOptional rollup@"^2.0.0||^3.0.0||^4.0.0" from @rollup/plugin-terser@0.4.4
npm ERR!   node_modules/@rollup/plugin-terser
npm ERR!     @rollup/plugin-terser@"^0.4.4" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer rollup@"^1.9.2 || ^2.0.0" from rollup-plugin-web-worker-loader@1.6.1
npm ERR! node_modules/rollup-plugin-web-worker-loader
npm ERR!   rollup-plugin-web-worker-loader@"^1.6.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: rollup@2.79.1
npm ERR! node_modules/rollup
npm ERR!   peer rollup@"^1.9.2 || ^2.0.0" from rollup-plugin-web-worker-loader@1.6.1
npm ERR!   node_modules/rollup-plugin-web-worker-loader
npm ERR!     rollup-plugin-web-worker-loader@"^1.6.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/nick/.npm/_logs/2024-05-14T20_13_08_656Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/nick/.npm/_logs/2024-05-14T20_13_08_656Z-debug-0.log

[jakubfiala]

hmm, I wonder why this didn't occur for me. But indeed, rollup-plugin-web-worker-loader specifies either rollup v1 or v2 as a peer dep. I think that's mostly because the package hasn't been updated in 2 years, and people seem to have pointed this out. I'll have a think about how to solve this, but I'd actually prefer not downgrading rollup over it now. Would you mind removing that change, too?

I'll then sort out the peer dep conflict and release everything as v4.3.0 hopefully within the next 3-4 days.

[jakubfiala]

AFAICT this is the actual fix, right? It's interesting because the ORs on L317-318 are there exactly to prevent drawing lines from (0,0). But now I see that #pointerUp also calls draw and that's probably where the unwanted lines are drawn. Thank you very much for spotting it!

[nichoth]

Yes, this is the fix. Sorry about all the incidental changes.

[jakubfiala]

no worries, I don't mind since you've explained your reasoning for them :)

[jakubfiala]

hey @nichoth, thanks for the fixes, I'll merge this now and sort out the remaining work around dependencies.