Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using rollup 3.0.0 #76

Open
dmnsgn opened this issue Jul 20, 2023 · 0 comments · May be fixed by #77
Open

Allow using rollup 3.0.0 #76

dmnsgn opened this issue Jul 20, 2023 · 0 comments · May be fixed by #77

Comments

@dmnsgn
Copy link

dmnsgn commented Jul 20, 2023

peerDeps are:

"peerDependencies": {
"rollup": "^1.9.2 || ^2.0.0"
}

so load is not up to date and this can clash and dedupe an already installed rollup 3.

Would you consider adding ^3.0.0 to it?

The only place I see it is used is here and the rollup API seems to be the same between v2 and v3:

rollup.rollup(inputOptions).then(bundle => {
state.exclude.delete(id);
state.exclude.delete(target);
const bundleOptions = {
format: 'iife',
name: 'worker_code',
sourcemap: true,
inlineDynamicImports: true,
};
bundle.generate(bundleOptions).then(result => {
resolve(handleBundleGenerated(state, config, addWatchFile, id, workerID, result));
}).catch(reject);
}).catch(reason => {
state.exclude.delete(id);
state.exclude.delete(target);
reject(reason);
});

@tgstern tgstern linked a pull request Aug 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant