Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bz2 as requirement and catch only exceptions that will be handled #28

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

sascha-egerer
Copy link

No description provided.

@sascha-egerer
Copy link
Author

The downloader need bz2 to extract the downloaded package. If bz2 is not available composer throws an exception witch is catched by the downloader and silently ignored. The Downloader just downloads every version and tries to extract it.

@jakoch
Copy link
Owner

jakoch commented Apr 11, 2016

Hey Sascha!

Ideally, the Composer require section would allow platform specific requirements,
e.g. require > linux > ext-bz2 (to express that ext-bz2 is only required on linux),
but unfortunately that isn't supported by Composer.

Thank you for contributing, especially for digging into the source and finding a silent exception.

Merging.

@jakoch jakoch merged commit 8a8252f into jakoch:master Apr 11, 2016
@sascha-egerer
Copy link
Author

Thanks for merging. Will there be a release soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants