-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tries to install PhantomJS 4 times and then finishes script, without error. But it is not installed. #40
Comments
Hey Wes! Thank you for reporting the issue. Which version of What you are describing is not reproducible for me, but must be close to the main download() function: https://github.com/jakoch/phantomjs-installer/blob/master/src/PhantomInstaller/Installer.php#L191-L203 I wonder why it tries to download over and over gain. I would expect the downloader to retry 3 times, then fail, see Composer/Downloader/FileDownloader L135 If it just can't save the file for some reason, it should throw an Maybe add an additional catch case: |
+1
Ubuntu 16.04 LTS |
I couldn't reproduce the issue (using Please add the additional catch block after Line 193 - to check, if the exception isn't bubbling up and display any download error.
|
I am using https://github.com/jonnnnyw/php-phantomjs which depends on phantomjs-installer 2.1.1. |
Thanks for the feedback. Glad you got it working. 👍 @t202wes Does an update to |
I have already sent a PR to php-phantomjs :) |
"two is better than one" :) Closed mine. |
Issue seems to be resolved. Closing. |
When composer tries to run the installPhantomJS method, it just tries to download phantomjs 4 times unsuccessfully. It does not error. The binary is not installed int he correct location.
I'm guessing that it just can't save the file for some reason and it's trying over and over again?
The text was updated successfully, but these errors were encountered: