Skip to content

Add about frame-ancestors CSP directive to readme #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 25, 2021
Merged

Add about frame-ancestors CSP directive to readme #46

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e23310
Add frame-ancestors to content security policy directives
mattdell Feb 10, 2021
f246aaf
Add frame-ancestors to README
mattdell Feb 11, 2021
4b40892
Remove `frameAncestor` type from readme
jagaapple Feb 25, 2021
4f1bf1d
Revert tests for enhancement
jagaapple Feb 25, 2021
9716ee4
Revert enhancement
jagaapple Feb 25, 2021
54e150f
Modify readme about `frameAncestors` directive in CSP
jagaapple Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,8 @@ blocks many XSS attacks, but Content Security Policy is recommended to use compa
| "allow-top-navigation-by-user-activation";
}>
& Partial<{
formAction: string | string[];
frameAncestors: string | string[];
navigateTo: string | string[];
reportURI: string | URL | (string | URL)[];
reportTo: string;
Expand All @@ -375,6 +377,11 @@ If you give true to `reportOnly` , this sets "Content-Security-Policy-Report-Onl

Also you can specify directives using chain-case names such as `child-src` instead of `childSrc` .

> **❗️ When setting `frameAncestors` :X-Frame-Options takes priority.**
> [Section "Relation to X-Frame-Options" of the CSP Spec](https://w3c.github.io/webappsec-csp/#frame-ancestors-and-frame-options) says: _"If a resource is delivered with a policy that includes a directive named frame-ancestors and whose disposition is "enforce", then the X-Frame-Options header MUST be ignored"_, but Chrome 40 & Firefox 35 ignore the frame-ancestors directive and follow the X-Frame-Options header instead.
>
> Therefore, if setting `frameAncestors` you should set `frameGuard` to `false`.

### `expectCT`
```ts
{
Expand Down