Skip to content

Conversation

mattdell
Copy link
Contributor

New Features

Changes and Fixes

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #46 (54e150f) into master (87f6129) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          208       208           
  Branches        85        85           
=========================================
  Hits           208       208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f6129...54e150f. Read the comment docs.

@mattdell mattdell force-pushed the add-frame-ancestors branch from 7f82b96 to 0a85072 Compare February 10, 2021 14:22
@mattdell
Copy link
Contributor Author

Must say I don't see how the code coverage is going down so much as I've added tests...! 😅

@mattdell mattdell mentioned this pull request Feb 10, 2021
2 tasks
@jagaapple
Copy link
Owner

Thank you for your pull request😃
I'm busy, so I'll review this within two weeks.

This feature will be merged in v2.2.0.

@mattdell mattdell force-pushed the add-frame-ancestors branch from 0a85072 to 9e23310 Compare February 10, 2021 19:35
@mattdell
Copy link
Contributor Author

That's great, @jagaapple

I figured out the issue with code coverage. I had left a .only in the unit tests...! 🤦🏻‍♂️

I will also add some documentation to the README when I get a chance.

@mattdell mattdell force-pushed the add-frame-ancestors branch 2 times, most recently from 16783b3 to 1a68f3b Compare February 11, 2021 13:57
@mattdell mattdell force-pushed the add-frame-ancestors branch from 1a68f3b to f246aaf Compare February 11, 2021 13:59
@helfi92
Copy link

helfi92 commented Feb 22, 2021

Looking forward to this! 🎉

@jagaapple
Copy link
Owner

jagaapple commented Feb 25, 2021

This PR is duplicated with #41 , but I will merge the README @mattdell edited about X-Frame-Options header.

Thank you!

@jagaapple jagaapple changed the title Add frame-ancestors to content security policy directives Add about frame-ancestors CSP directive to readme Feb 25, 2021
@jagaapple jagaapple changed the base branch from master to release/v2.2.0 February 25, 2021 15:31
@jagaapple jagaapple mentioned this pull request Feb 25, 2021
@jagaapple jagaapple merged commit 2547257 into jagaapple:release/v2.2.0 Feb 25, 2021
jagaapple added a commit that referenced this pull request Feb 25, 2021
# New Features
- Add navigation directives #41 
  - Move to `navigation-to` directive from `ReportingDirective` to `NavigationDirective`
- Add about frame-ancestors CSP directive to readme #46


# Changes and Fixes
- Modify English in readme
- Update dev dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for frame-ancestors
3 participants