Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed alpine image from 3.16 to 3.19.0 #5453

Closed
wants to merge 9 commits into from
Closed

fix: changed alpine image from 3.16 to 3.19.0 #5453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
46ed991
Update Dockerfile
prakrit55 May 15, 2024
1ac5fa9
Update Makefile
prakrit55 May 15, 2024
6c6b74e
Update Dockerfile
prakrit55 May 15, 2024
cb713ff
Update Makefile
prakrit55 May 15, 2024
2b5b02a
Update Makefile
prakrit55 May 15, 2024
514f04f
Update Dockerfile
prakrit55 May 15, 2024
3cc2ea8
Update Makefile
prakrit55 May 15, 2024
82a554e
Update Dockerfile
prakrit55 May 15, 2024
b29829b
Update Dockerfile
prakrit55 May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions docker/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
VERSION := 1.0.0
ROOT_IMAGE ?= alpine:3.16
CERT_IMAGE := $(ROOT_IMAGE)
GOLANG_IMAGE := golang:1.22-alpine

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all 3 vars

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I remove the arg declaration used in building the image too

DOCKER_REGISTRY ?= localhost:5000
Expand All @@ -12,8 +9,6 @@ create-baseimg-debugimg: create-baseimg create-debugimg

create-baseimg: prepare-docker-buildx
docker buildx build -t $(BASE_IMAGE) --push \
--build-arg root_image=$(ROOT_IMAGE) \
--build-arg cert_image=$(CERT_IMAGE) \
--platform=$(PLATFORMS) \
docker/base

Expand Down
4 changes: 2 additions & 2 deletions docker/base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG cert_image
ARG root_image
ARG cert_image=alpine:3.19.0
ARG root_image=alpine:3.19.0

FROM $cert_image AS cert
RUN apk add --update --no-cache ca-certificates mailcap
Expand Down
Loading