fix: changed alpine image from 3.16 to 3.19.0 #5453
Conversation
change alpine image from 3.16 to 3.16.9 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
change alpine image in makefile Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
|
@prakrit55 I think it's not satisfying the issue requirements of what @yurishkuro intended:
|
It's fine to independently do a one-time manual upgrade.
Please read the issue description more carefully. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5453 +/- ##
===========================================
- Coverage 95.46% 37.88% -57.59%
===========================================
Files 331 160 -171
Lines 16113 8343 -7770
===========================================
- Hits 15383 3161 -12222
- Misses 556 4877 +4321
- Partials 174 305 +131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
my bad @yurishkuro WDYT, which alpine image tag would be more compatible... is it the latest |
|
Refer this => https://alpinelinux.org/releases/ v3.19 is the latest stable version |
yes much thought of it, thanks |
fixing alpine image version from 3.16 to 3.19 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fixing alpine image in makefile from 3.16 to 3.19 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
prakrit55
changed the title
docker/Makefile
Outdated
| @@ -1,5 +1,5 @@ | |||
| VERSION := 1.0.0 | |||
| ROOT_IMAGE ?= alpine:3.16 | |||
| ROOT_IMAGE ?= alpine:3.19 | |||
There was a problem hiding this comment.
for repeatable builds we should be using exact version, in this case 3.19.1
docker/base/Dockerfile
Outdated
| @@ -1,9 +1,9 @@ | |||
| ARG cert_image | |||
| ARG root_image | |||
|
|
|||
| FROM $cert_image AS cert | |||
| FROM alpine:3.19 AS cert | |||
There was a problem hiding this comment.
what was the reason a variable was used?
There was a problem hiding this comment.
since the the CERT_IMAGE is based on the ROOT_IMAGE in the makefile, shouldn't we change it here too
There was a problem hiding this comment.
I would remove all 3 variables that define versions from the Makefile (and places where they are passed in) and just give default values to the vars
changing alpine image to 3.19.1 in makefile Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
docker/base/Dockerfile
Outdated
| @@ -1,9 +1,9 @@ | |||
| ARG cert_image | |||
| ARG root_image | |||
There was a problem hiding this comment.
use ARG VARIABLE_NAME=default_value
There was a problem hiding this comment.
and let's use 3.19.0, not 3.19.1, this will give us a chance to test dependabot upgrading it to 3.19.1
fixing alpine image Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
prakrit55
changed the title
| @@ -1,5 +1,5 @@ | |||
| VERSION := 1.0.0 | |||
| ROOT_IMAGE ?= alpine:3.16 | |||
| ROOT_IMAGE ?= alpine:3.19.1 | |||
| CERT_IMAGE := $(ROOT_IMAGE) | |||
| GOLANG_IMAGE := golang:1.22-alpine | |||
There was a problem hiding this comment.
should I remove the arg declaration used in building the image too
removed root_image and cert_image vars and their usable functions from makefile Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
fixed image in dockerfile Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
revising to alpine:3.19.0 Signed-off-by: Prakriti Mandal <98270250+prakrit55@users.noreply.github.com>
prakrit55
changed the title
Which problem is this PR solving?
fix: #5450
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test