Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E testing for Rollover ES feature #1504

Closed
wants to merge 5 commits into from
Closed

Add E2E testing for Rollover ES feature #1504

wants to merge 5 commits into from

Conversation

iblancasa
Copy link
Collaborator

Which problem is this PR solving?

Add E2E testing to the Rollover ES feature implemented in #267

Short description of the changes

  • Added smoke E2E Test for the Rollover ES feature
  • Added E2E Test to check everything works properly when the feature is enabled after the deployment
  • Added E2E Test to check the correct indices are created when the feature is enabled before the deployment
  • Extract some common logic from the ES index test suite to reuse some logic in the Rollover ES test

@iblancasa
Copy link
Collaborator Author

Todo:

  • Add testing for the readTTL parameter

@iblancasa iblancasa force-pushed the rollover-testing branch 2 times, most recently from 85b4cc5 to b689478 Compare July 9, 2021 14:12
@iblancasa iblancasa changed the title Add E2E testing for Rollover ES feature [WIP] Add E2E testing for Rollover ES feature Jul 9, 2021
@jkandasa
Copy link
Member

@iblancasa you have to sign off your commit. See the details of DCO

@iblancasa iblancasa force-pushed the rollover-testing branch 2 times, most recently from 8264839 to 8de5b76 Compare July 12, 2021 14:55
@jpkrohling jpkrohling marked this pull request as draft July 13, 2021 11:58
iblancasa and others added 3 commits July 20, 2021 20:52
@iblancasa
Add E2E testing for Rollover ES feature
91c58c7 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa
Add E2E testing for Rollover feature using the RReadTTL parameter
463ae7e 
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@jan25 @jpkrohling @iblancasa
Fix example cr manifest path (jaegertracing#1511)
ed9e3ab 
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Israel Blancas <iblancas@redhat.com>
@iblancasa iblancasa marked this pull request as ready for review July 20, 2021 18:53
@iblancasa iblancasa changed the title [WIP] Add E2E testing for Rollover ES feature Add E2E testing for Rollover ES feature Jul 20, 2021
jpkrohling
jpkrohling reviewed Jul 21, 2021
View reviewed changes
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New e2e tests should be written using kuttl.

See https://github.com/jaegertracing/jaeger-operator/tree/master/tests/e2e

@iblancasa
Copy link
Collaborator Author

@jpkrohling, ok I'll rewrite the tests using kuttl

@iblancasa iblancasa closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iblancasa @jkandasa @jpkrohling @jan25