Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix outdated contributing.md example #1511

Merged
merged 2 commits into from
Jul 19, 2021
Merged

Conversation

jan25
Copy link
Contributor

@jan25 jan25 commented Jul 18, 2021

Signed-off-by: Abhilash Gnan abhilashgnan@gmail.com

Which problem is this PR solving?

Fixes #1498

Short description of the changes

Fixed path to example cr manifest in contributing guide.

Sidenote: I didn't have success with kubectl apply -f examples/simplest.yaml because i'm on M1 mac and couldn't setup older operator-sdk. Though jeagers resource was created but with no pods.

Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #1511 (3eafa38) into master (e6b4930) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1511   +/-   ##
=======================================
  Coverage   87.91%   87.91%           
=======================================
  Files          92       92           
  Lines        5766     5766           
=======================================
  Hits         5069     5069           
  Misses        532      532           
  Partials      165      165           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b4930...3eafa38. Read the comment docs.

@jpkrohling jpkrohling enabled auto-merge (squash) July 19, 2021 07:40
@jpkrohling jpkrohling merged commit ba4bcf5 into jaegertracing:master Jul 19, 2021
iblancasa pushed a commit to iblancasa/jaeger-operator that referenced this pull request Jul 20, 2021
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>

Co-authored-by: Juraci Paixão Kröhling <juraci@kroehling.de>
Signed-off-by: Israel Blancas <iblancas@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated CONTRIBUTING.md
2 participants