fix(tests): update mocks for resolveBvid and Windows platform guards#749
Merged
fix(tests): update mocks for resolveBvid and Windows platform guards#749
Conversation
- bilibili subtitle/comments tests: use importOriginal to include resolveBvid in utils mock - comments test: use valid BV ID format for aid-resolution error test - launcher test: skip pgrep test on win32 (detectProcess early-returns)
just-buer
pushed a commit
to just-buer/opencli
that referenced
this pull request
Apr 8, 2026
…ackwener#749) - bilibili subtitle/comments tests: use importOriginal to include resolveBvid in utils mock - comments test: use valid BV ID format for aid-resolution error test - launcher test: skip pgrep test on win32 (detectProcess early-returns)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveBvidviaimportOriginal(broken after feat(bilibili): support b23.tv short URL/short code resolution #740)BV_invalid→BVinvalid123) to match BV regex patterndetectProcesspgrep test on Windows where it early-returnsfalse(fix(launcher): graceful degradation and manual CDP override for Windows #744)Test plan