fix(launcher): graceful degradation and manual CDP override for Windows#744
Merged
jackwener merged 2 commits intojackwener:mainfrom Apr 3, 2026
Merged
Conversation
Fail-fast with a clear error if the manual CDP endpoint is not reachable, instead of passing a bad URL downstream and getting a confusing error.
1 task
just-buer
pushed a commit
to just-buer/opencli
that referenced
this pull request
Apr 8, 2026
…ws (jackwener#744) * fix(windows): graceful degradation and manual CDP override for Electron apps * fix: validate OPENCLI_CDP_ENDPOINT with probeCDP before use Fail-fast with a clear error if the manual CDP endpoint is not reachable, instead of passing a bad URL downstream and getting a confusing error. --------- Co-authored-by: jackwener <jakevingoo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug on Windows where start up crashes due to Unix specific commands (pgrep, pkill, osascript). It prioritizes the \OPENCLI_CDP_ENDPOINT\ environment variable and adds platform guards.