Play 'default' sound for iOS notifications.

Fixes zulip/zulip-mobile#2651. This was tested on an iPhone 7 running iOS 12.
jackrzhang · Nov 2, 2018 · d5b1a3a · d5b1a3a
1 parent 1490653
commit d5b1a3a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/zerver/lib/push_notifications.py b/zerver/lib/push_notifications.py
@@ -555,6 +555,7 @@ def get_apns_payload(user_profile: UserProfile, message: Message) -> Dict[str, A
             'subtitle': get_apns_alert_subtitle(message),
             'body': content,
         },
+        'sound': 'default',
         'badge': 0,  # TODO: set badge count in a better way
         'custom': {'zulip': zulip_data},
     }

diff --git a/zerver/tests/test_push_notifications.py b/zerver/tests/test_push_notifications.py
@@ -750,6 +750,7 @@ def test_get_apns_payload_personal_message(self) -> None:
                 'body': message.content,
             },
             'badge': 0,
+            'sound': 'default',
             'custom': {
                 'zulip': {
                     'message_ids': [message.id],
@@ -778,6 +779,7 @@ def test_get_apns_payload_huddle_message(self) -> None:
                 'subtitle': 'King Hamlet:',
                 'body': message.content,
             },
+            'sound': 'default',
             'badge': 0,
             'custom': {
                 'zulip': {
@@ -811,6 +813,7 @@ def test_get_apns_payload_stream_message(self):
                 'subtitle': 'King Hamlet:',
                 'body': message.content,
             },
+            'sound': 'default',
             'badge': 0,
             'custom': {
                 'zulip': {
@@ -842,6 +845,7 @@ def test_get_apns_payload_stream_mention(self):
                 'subtitle': 'King Hamlet mentioned you:',
                 'body': message.content,
             },
+            'sound': 'default',
             'badge': 0,
             'custom': {
                 'zulip': {
@@ -874,6 +878,7 @@ def test_get_apns_payload_redacted_content(self) -> None:
                 'subtitle': "King Hamlet:",
                 'body': "***REDACTED***",
             },
+            'sound': 'default',
             'badge': 0,
             'custom': {
                 'zulip': {