-
Notifications
You must be signed in to change notification settings - Fork 32
Add option for users to generate minified stylesheets using the build:minify command #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR cleans up my mistakes in #145 of committing the |
jackdomleo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for picking this up @tannerdolby! Just left a few comments, then we'd be good to go with this PR 🙂
|
You're welcome @jackdomleo7! I'm glad you mentioned using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks brilliant! Thank you. Just 1 merge conflict.
|
Ok great! You're welcome. Ah, gotcha I will resolve that merge conflict real quick. |
jackdomleo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Sorry, I didn't realise I could push changes to your branch and I only just thought about the things I committed and didn't want to have this PR hanging around for longer 🙂
|
Sorry @tannerdolby... I added some commits that I forgot when reviewing, then the tests wouldn't run. Even though I didn't touch the tests. Then I had to add a few more commits, including adding Anyway, thank you for this! |
|
No worries @jackdomleo7! You're welcome :) Thanks for adding the commits needed to push this through. Yeah I didn't think Thank you for reviewing and seeing this through! 🙂 |
Description
Fixes #144
Why is this important?
This will allow users to generate minified stylesheets with
npm run build:minify, it currently generates the minified files at the root directory as<original_filename>-minified.css. If a user wanted to only generate one of the stylesheets or two, we could add that logic.Covered test cases
No test cases have been added yet.
Did you test on all major browsers?
T&Cs