Add option to generate minified stylesheets #145
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should be a step in the right direction. I left comments in the
minify.jssource to address things in code review and then we can remove most of the comments when this is closer to being "finished".Why is this important?
This allows users to take advantage of the
build:minifycommand to generated minified versions of each stylesheet.Covered test cases
Haven't written any tests for this yet
Did you test on all major browsers?
I apologize for including the
package-lock.jsonin the first commit, it has a large diff (-6k) so I'm happy to remove that commit if you need.Well I tried using
git rm package-lock.jsonwithgit commit -a -m "msg"but messed things up, unless I do a rebase the 6k diff from package-lock.json in the first commit will stay. I'm completely okay with creating a fresh PR that doesn't include a committed package-lock.json to avoid such a large diff, just let me know.T&Cs