-
-
Notifications
You must be signed in to change notification settings - Fork 129
Replace serde-yaml with serde-saphyr (again) #1520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
- Coverage 92.02% 91.93% -0.09%
==========================================
Files 89 89
Lines 18500 18288 -212
==========================================
- Hits 17024 16813 -211
+ Misses 1476 1475 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
serde-saphyr has way better error message, and it is written in safe Rust.
📦 Cargo Bloat ComparisonBinary size change: +3.10% (22.6 MiB → 23.3 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
| | | ||
| 1 | repos: | ||
| 2 | - repo: https://github.com/crate-ci/typos | ||
| | ^ Invalid remote repo: missing field `id` at line 2, column 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be at the line 4
serde-saphyr has way better error message, and it is written in safe Rust.
Previous try: #1087
Previous revert: #1106 and #1112
TODO:
Replace serialize_yaml_scalar with serde-saphyr as well:
prek/crates/prek/src/yaml.rs
Lines 12 to 13 in 0a4be22