-
-
Notifications
You must be signed in to change notification settings - Fork 129
Revert back to use serde_yaml again
#1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
215de30 to
26e86aa
Compare
serde_yaml againserde_yaml again
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1112 +/- ##
===========================================
- Coverage 89.85% 26.97% -62.88%
===========================================
Files 72 73 +1
Lines 13432 13471 +39
===========================================
- Hits 12069 3634 -8435
- Misses 1363 9837 +8474 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: -1.81% (16.6 MiB → 16.3 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
serde-saphyr has way better error message, and it is written in safe Rust. Previous try: #1087 Previous revert: #1106 and #1112 TODO: Replace serialize_yaml_scalar with serde-saphyr as well: https://github.com/j178/prek/blob/0a4be22599076b8c6273940b2760828b442c78f4/crates/prek/src/yaml.rs#L12-L13
It's a good experiment anyway, I'll keep looking at serde-saphyr.
Closes #1111