Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPThemes not overriding ChatGPT theme mode after page refresh #48

Closed
itsmartashub opened this issue Sep 13, 2024 · 0 comments · Fixed by #52
Closed

GPThemes not overriding ChatGPT theme mode after page refresh #48

itsmartashub opened this issue Sep 13, 2024 · 0 comments · Fixed by #52
Assignees
Labels
Bug Something isn't working Status: WIP Work In Progress

Comments

@itsmartashub
Copy link
Owner

Recently, GPThemes no longer consistently overrides the ChatGPT theme when switching themes.
Specifically, if the ChatGPT theme is set to light/dark, and a different theme is selected via GPThemes, the ChatGPT theme will take precedence after a page refresh. This behaviour should be reversed so that GPThemes always overrides the ChatGPT theme.

@itsmartashub itsmartashub added the Bug Something isn't working label Sep 13, 2024
@itsmartashub itsmartashub self-assigned this Sep 13, 2024
@itsmartashub itsmartashub changed the title GPThemes not overriding ChatGPT theme after page refresh GPThemes not overriding ChatGPT theme mode after page refresh Sep 15, 2024
@itsmartashub itsmartashub added the Status: WIP Work In Progress label Sep 15, 2024
itsmartashub added a commit that referenced this issue Sep 15, 2024
- Rewrite theme changing logic to improve functionality and consistency
- Identify and address potential issues with theme inconsistencies
- Warn about potential risks of broken themes due to conflicting settings

Changes summary:
- Rewrote the theme changing logic to improve its functionality and consistency, but introduced potential risks of broken themes due to conflicting settings between GPT settings and GPT themes.
- Identified the need to review and update all elements to ensure correct styling and avoid color scheme inconsistencies.
- Noted the risk of theme breakage if users choose conflicting themes between GPT settings and GPT themes, which may result in poor visibility or inconsistent colors.
itsmartashub added a commit that referenced this issue Sep 15, 2024
)

- Rewrite the theme manager to directly mutate the value of GPT theme in local storage, eliminating the need for storage.sync
- Ensure that theme changes from GPT settings are now reflected in the floating theme and are in sync
- Note: There is a small issue with dark and accent themes on the "/share/*" page due to overriding code

Changes summary:
- Improved the theme management system:
  - Replaced the use of storage.sync with direct mutation of the GPT theme value in local storage, enhancing performance and reliability.
  - Ensured that theme changes from GPT settings are now properly reflected in the floating theme, maintaining a consistent user experience.
  - Identified a minor issue with dark and accent themes on the "/share/*" page, which will require further attention to resolve the overriding code.
itsmartashub added a commit that referenced this issue Sep 16, 2024
GPThemes not overriding ChatGPT theme mode after page refresh (#48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Status: WIP Work In Progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant