GPThemes not overriding ChatGPT theme mode after page refresh (#48) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) - Rewrite the theme manager to directly mutate the value of GPT theme in local storage, eliminating the need for storage.sync - Ensure that theme changes from GPT settings are now reflected in the floating theme and are in sync - Note: There is a small issue with dark and accent themes on the "/share/*" page due to overriding code Changes summary: - Improved the theme management system: - Replaced the use of storage.sync with direct mutation of the GPT theme value in local storage, enhancing performance and reliability. - Ensured that theme changes from GPT settings are now properly reflected in the floating theme, maintaining a consistent user experience. - Identified a minor issue with dark and accent themes on the "/share/*" page, which will require further attention to resolve the overriding code.
… unnecessary keys that were previously used for theme management - Remove left storage.sync keys related to theme management, as they are no longer needed with the switch to storage.local Changes summary: - Removed obsolete storage.sync keys: - Cleaned up storage by removing unnecessary keys that were previously used for theme management, ensuring a more organized and efficient storage system.
- Replace the long if statement with a more concise and readable version using Object.values(THEMES).includes(themeButtonID) Changes summary: - Simplified the theme button ID check: - Replaced a lengthy if statement with a more efficient and readable version, improving code maintainability and reducing complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(theme-mode-consistency): Sync GPT theme mode with GPThemes (#48)
/share/*page due to overriding codeChanges summary:
storage.syncwith direct mutation of the GPT theme value in local storage, enhancing performance and reliability./share/*page, which will require further attention to resolve the overriding code.