Fix buffer overflow and add missing documentation for Prometheus v2 endpoint #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed commit 7849f30 which adds Prometheus v2 output format with automatic label extraction. Found buffer overflow vulnerability and missing user documentation.
Issues Fixed
Buffer Overflow in prometheus_v2_out_stat
Fixed-size 512-byte buffers used with
snprintf()for concatenating metric names and labels. Long metric names likeproxy.process.cache.volume_0.lookup.successwith multiple labels could exceed buffer size, causing truncation.Before:
After:
Missing Documentation
Added documentation for Prometheus v2 format in
stats_over_http.en.rst:/_stats/prometheus_v2text/plain; version=2.0.0Review Summary
swoc::TextViewFull review at
/tmp/COMMIT_REVIEW_7849f30.mdOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.