Skip to content

chore(deps): update demo digest to b80757b #5950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(deps): update demo digest to b80757b #5950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36c4561
chore(deps): update demo digest to b80757b
renovate[bot] Aug 19, 2025
bbe4a87
bump the timeout
skshetry Aug 19, 2025
528628c
pin to 1.100.3
skshetry Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion demo
Open in desktop
Submodule demo updated 2 files
+1 −1 .github/CODEOWNERS
+4 −4 requirements.txt
1 change: 1 addition & 0 deletions extension/src/test/e2e/extension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ describe('Plots Webview', function () {
await waitForDvcToFinish()
await webview.focus()

console.log('6')
await waitForAllPlotsToRender(webview, 6)

await expectAllPlotsToBeFilled(webview)
Expand Down
4 changes: 3 additions & 1 deletion extension/src/test/e2e/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,9 @@ export const waitForAllPlotsToRender = (
): Promise<true | void> => {
return browser.waitUntil(
async () => {
return (await webview.vegaVisualization$$.length) === plotsAmount
const actual = await webview.vegaVisualization$$.length
console.log('expected', plotsAmount, 'got', actual)
return actual === plotsAmount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skshetry from what has been logged out it looks like the runDeleteCommand function is not actually deleting the custom plot anymore. I.e the code below is no longer working:

vscode-dvc/extension/src/test/e2e/extension.test.ts

Lines 176 to 182 in 8db627c

await deleteCustomPlots()
await workbench.executeCommand('DVC: Show Plots')
await waitForDvcToFinish()
await webview.focus()
await waitForAllPlotsToRender(webview, 5)

Copy link
Contributor

@mattseddon mattseddon Aug 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From manual testing it looks like the functionality is actually broken. The delete command runs but the data in the webview is not updated until after the webview has been closed/reopened.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I was trying to look into this briefly :) was not able to lauch e2e tests locally within 1 hour - setup is quite involved and breaks now.

I'll try to check what is going on when / if I have a bit more time. Thanks @mattseddon for the review / feedback ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, tested manually in the Extension Development Host in the demo project - works for me.. @mattseddon how were you running / testing it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't run yarn test:e2e though ...

Uncaught Exception:
Error: Cannot find package 'electron' imported from /Users/ivan/Projects/vscode-dvc/extension/.wdio-vscode-service/vscode-darwin-arm64-1.103.2/Visual Studio Code.app/Contents/Resources/app/out/main.js
at packageResolve (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:757:9)
at moduleResolve (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:798:18)
at Object.defaultResolve (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:912:11)
at /Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:218:35
at entrypointFallback (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:168:34)
at /Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:217:14
at addShortCircuitFlag (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:409:21)
at resolve (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:197:12)

not sure if this is expected ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't run it either, it will take a fair bit of effort to jump the gap between when we were actively maintaining the extension and now. The VS Code API might have changed and might not support Node 16 anymore. It looks like webdriver could be an issue too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, tested manually in the Extension Development Host in the demo project - works for me.. @mattseddon how were you running / testing it?

I tested the same way as you. I had 6 custom plots, I deleted one and then I still had 6.

},
{ timeout: 30000 }
)
Expand Down
2 changes: 1 addition & 1 deletion extension/src/test/e2e/wdio.conf.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const config: Options.Testrunner = {
capabilities: [
{
browserName: 'vscode',
browserVersion: 'stable',
browserVersion: '1.100.3',
'wdio:vscodeOptions': {
extensionPath,
userSettings: {
Expand Down
Loading