chore(deps): update demo digest to b80757b #5950
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/demo-digest
branch
from
a318b5f to
36c4561
Compare
skshetry
force-pushed
the
renovate/demo-digest
branch
from
d818d64 to
d82599b
Compare
skshetry
force-pushed
the
renovate/demo-digest
branch
from
d82599b to
bbe4a87
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| return (await webview.vegaVisualization$$.length) === plotsAmount | ||
| const actual = await webview.vegaVisualization$$.length | ||
| console.log('expected', plotsAmount, 'got', actual) | ||
| return actual === plotsAmount |
There was a problem hiding this comment.
@skshetry from what has been logged out it looks like the runDeleteCommand function is not actually deleting the custom plot anymore. I.e the code below is no longer working:
vscode-dvc/extension/src/test/e2e/extension.test.ts
Lines 176 to 182 in 8db627c
There was a problem hiding this comment.
From manual testing it looks like the functionality is actually broken. The delete command runs but the data in the webview is not updated until after the webview has been closed/reopened.
There was a problem hiding this comment.
yep, I was trying to look into this briefly :) was not able to lauch e2e tests locally within 1 hour - setup is quite involved and breaks now.
I'll try to check what is going on when / if I have a bit more time. Thanks @mattseddon for the review / feedback ...
There was a problem hiding this comment.
Hmm, tested manually in the Extension Development Host in the demo project - works for me.. @mattseddon how were you running / testing it?
There was a problem hiding this comment.
I can't run yarn test:e2e though ...
Uncaught Exception:
Error: Cannot find package 'electron' imported from /Users/ivan/Projects/vscode-dvc/extension/.wdio-vscode-service/vscode-darwin-arm64-1.103.2/Visual Studio Code.app/Contents/Resources/app/out/main.js
at packageResolve (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:757:9)
at moduleResolve (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:798:18)
at Object.defaultResolve (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/dist-raw/node-internal-modules-esm-resolve.js:912:11)
at /Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:218:35
at entrypointFallback (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:168:34)
at /Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:217:14
at addShortCircuitFlag (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:409:21)
at resolve (/Users/ivan/Projects/vscode-dvc/node_modules/ts-node/src/esm.ts:197:12)
not sure if this is expected ...
There was a problem hiding this comment.
I couldn't run it either, it will take a fair bit of effort to jump the gap between when we were actively maintaining the extension and now. The VS Code API might have changed and might not support Node 16 anymore. It looks like webdriver could be an issue too.
There was a problem hiding this comment.
Hmm, tested manually in the Extension Development Host in the demo project - works for me.. @mattseddon how were you running / testing it?
I tested the same way as you. I had 6 custom plots, I deleted one and then I still had 6.
skshetry
force-pushed
the
renovate/demo-digest
branch
from
010dead to
528628c
Compare
This PR contains the following updates:
9f5910a->b80757bConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.