Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular updates (March 10) #1040

Merged
merged 3 commits into from
Mar 14, 2020
Merged

Regular updates (March 10) #1040

merged 3 commits into from
Mar 14, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Mar 10, 2020

@shcheklein shcheklein temporarily deployed to dvc-landing-2020-03-09-i7xrewk March 10, 2020 18:53 Inactive
@shcheklein
Copy link
Member

@jorgeorpinel it's already 22 files, time to review :) ?

@jorgeorpinel
Copy link
Contributor Author

@shcheklein OK I'll stop adding changes even when everything has to do with term "flag" and "option" but this needs to wait until the previous regular updates is merged, the file count will be reduced then.

@shcheklein
Copy link
Member

@jorgeorpinel sounds good! will try to review that one today!

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-09-i7xrewk March 11, 2020 20:36 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review March 12, 2020 06:00
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-09-i7xrewk March 12, 2020 06:20 Inactive
@jorgeorpinel jorgeorpinel requested a review from shcheklein March 12, 2020 08:17
@jorgeorpinel
Copy link
Contributor Author

Oops sorry Ivan, I guess this PR stayed big even after merging the previous ones 😢 and I have one last round of updates regarding the "options" term and some missing instances that should've ben done in the recent PRs, but will keep them stashed for a later PR after this.

@jorgeorpinel
Copy link
Contributor Author

p.s. ah it did decrease from 22 to 19 files actually! I was seeing 30 when I wrote that ^ OK not so bad then. Still, keeping my current stash for now.

@shcheklein shcheklein merged commit 01ed81c into master Mar 14, 2020
@jorgeorpinel jorgeorpinel deleted the 2020-03-09 branch March 21, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants