Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular updates (late Feb) #1014

Merged
merged 15 commits into from
Mar 12, 2020
Merged

Regular updates (late Feb) #1014

merged 15 commits into from
Mar 12, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 22, 2020 •
edited
Loading

@shcheklein shcheklein temporarily deployed to dvc-landing-2020-02-21-wgkziif February 22, 2020 00:50 Inactive
@weekly-digest weekly-digest bot mentioned this pull request Feb 23, 2020
Closed
@jorgeorpinel jorgeorpinel mentioned this pull request Feb 24, 2020
Merged
1 task
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-02-21-wgkziif February 24, 2020 06:51 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-02-21-wgkziif February 28, 2020 00:13 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-02-21-wgkziif February 28, 2020 06:51 Inactive
@jorgeorpinel jorgeorpinel mentioned this pull request Feb 28, 2020
Merged
3 tasks
@weekly-digest weekly-digest bot mentioned this pull request Mar 1, 2020
Closed
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-02-21-wgkziif March 4, 2020 05:59 Inactive
@jorgeorpinel jorgeorpinel changed the title Regular updates (Feb 21) Regular updates (Early March) Mar 9, 2020
@jorgeorpinel jorgeorpinel marked this pull request as ready for review March 9, 2020 22:36
@jorgeorpinel jorgeorpinel mentioned this pull request Mar 9, 2020
Merged
@jorgeorpinel jorgeorpinel changed the title Regular updates (Early March) Regular updates (early March) Mar 9, 2020
@jorgeorpinel jorgeorpinel changed the title Regular updates (early March) Regular updates (late Feb) Mar 9, 2020
@jorgeorpinel jorgeorpinel requested a review from shcheklein March 10, 2020 18:38
@jorgeorpinel jorgeorpinel mentioned this pull request Mar 10, 2020
Merged
1 task
shcheklein
shcheklein approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but please check my comment on the config, .gitignore - may be you can come with some better way to handle that?

jorgeorpinel
jorgeorpinel commented Mar 11, 2020
View reviewed changes
public/static/docs/command-reference/metrics/index.md
modify Modify metric file options.
modify Modify metric file values.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened iterative/dvc/pull/3471 to match this (and other output string updates).

@jorgeorpinel jorgeorpinel mentioned this pull request Mar 11, 2020
Merged
3 tasks
@jorgeorpinel jorgeorpinel requested a review from shcheklein March 12, 2020 01:15
@jorgeorpinel jorgeorpinel merged commit fa9d376 into master Mar 12, 2020
@jorgeorpinel jorgeorpinel deleted the 2020-02-21 branch March 21, 2020 03:01
efiop pushed a commit to iterative/dvc that referenced this pull request Mar 23, 2020
@jorgeorpinel
dvc: update cmd output strings to match docs (#3471)
9e77405 
* metrics show: update -h output to match docs
per iterative/dvc.org@2c34521

* metric: update argument desc per iterative/dvc.org/pull/1014

* metrics: match iterative/dvc.org/pull/1014 again...
using term "formatting" instead of "options"

* list: update help output to match iterative/dvc.org/pull/1014
That's iterative/dvc.org/pull/1014

* dvc: add docstring to open_by_relpath
It's a public fn after all. Similar to Repo class

* help: update cmd output strings to match with docs

* remote: update help output

* term: file descriptor -> file object

* metrics: update add and remove help outputs
per #3471 (review)

* remove: update help output
per #3471 (review)

* root: update help output
per #3471 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein Awaiting requested review from shcheklein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does DVC support rsync remotes?
2 participants
@jorgeorpinel @shcheklein