Skip to content

Fix links in documentation #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2021
Merged

Fix links in documentation #146

merged 3 commits into from
Oct 1, 2021

Conversation

tmotyl
Copy link
Contributor

@tmotyl tmotyl commented Sep 29, 2021

No description provided.

@shcheklein
Copy link
Member

thanks @tmotyl for taking care of this.

I think all link should start with ./PyDrive2/.. ... e.g.

https://docs.iterative.ai/PyDrive2/pydrive2/#pydrive2.apiattr.ApiResource
https://docs.iterative.ai/PyDrive2/quickstart/#creating-and-updating-files

./pydrive2/#pydrive2.apiattr.ApiResource alone won't be enough.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix links prefix

@tmotyl
Copy link
Contributor Author

tmotyl commented Sep 29, 2021

Why do you think so? My previous patch fixed links.

@tmotyl
Copy link
Contributor Author

tmotyl commented Sep 29, 2021

Please notice that i hanged links to absolute path(no dot at beginning).

@shcheklein
Copy link
Member

I did this commit after we merged to fix this - 1d0847a

(I'm not sure about . - I hope it's pretty much the same w or w/o it to be honest)

@tmotyl
Copy link
Contributor Author

tmotyl commented Sep 30, 2021

thanks for the explanation, here you go :)

@shcheklein
Copy link
Member

Thanks @tmotyl !

@shcheklein shcheklein merged commit 73d96d6 into iterative:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants