Skip to content

Fix links to /pydrive2/ #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix links to /pydrive2/ #144

merged 1 commit into from
Sep 29, 2021

Conversation

tmotyl
Copy link
Contributor

@tmotyl tmotyl commented Sep 28, 2021

@tmotyl
Copy link
Contributor Author

tmotyl commented Sep 28, 2021

looks like test failures are false positives

@shcheklein shcheklein merged commit ba1abbc into iterative:master Sep 29, 2021
@shcheklein
Copy link
Member

Thanks @tmotyl !

@shcheklein
Copy link
Member

looks like test failures are false positives

CI doesn't run in forks, no worries about that in this case.

@shcheklein
Copy link
Member

shcheklein commented Sep 29, 2021 •
edited
Loading

Links are still broken, btw. I think we should update pydrive2 to PyDrive2 in the URLs:

https://docs.iterative.ai/PyDrive2/#pydrive2.files.GoogleDriveFile

@tmotyl
Copy link
Contributor Author

tmotyl commented Sep 29, 2021 •
edited
Loading

@shcheklein where did you get this link from?
The links on "file management made easy" are working after this patch e.g. "GoogleDriveFile " link
image

@tmotyl
Copy link
Contributor Author

tmotyl commented Sep 29, 2021 •
edited
Loading

I see there are other places which needs similar fix:
see: #146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmotyl @shcheklein