Skip to content

Commit

Permalink
tools: remove out-of-date code-cache-path comment
Browse files Browse the repository at this point in the history
This commit removes the comment in cache_builder.cc regarding the usage
of --code-cache-path with configure.

Commit 14df42f ("build: run
`mkcodecache` as an action") deprecated this option and it is always
set to yes (unless cross compiling).

PR-URL: nodejs#28419
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
danbev committed Jun 28, 2019
1 parent fcf2da0 commit d8a5361
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tools/code_cache/cache_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ static std::string GenerateCodeCache(
ss << R"(#include <cinttypes>
#include "node_native_module_env.h"
// This file is generated by tools/mkcodecache
// and is used when configure is run with \`--code-cache-path\`
// This file is generated by mkcodecache (tools/code_cache/mkcodecache.cc)
namespace node {
namespace native_module {
Expand Down

0 comments on commit d8a5361

Please sign in to comment.