tools: remove out-of-date code-cache-path comment #28419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the comment in cache_builder.cc regarding the usage of --code-cache-path with configure. Commit 14df42f ("build: run `mkcodecache` as an action") deprecated this option and it is always set to yes (unless cross compiling).
BridgeAR
approved these changes
Jun 25, 2019
jasnell
approved these changes
Jun 25, 2019
trivikr
approved these changes
Jun 25, 2019
Trott
approved these changes
Jun 25, 2019
lpinca
approved these changes
Jun 26, 2019
joyeecheung
approved these changes
Jun 27, 2019
danbev
added
the
author ready
|
Landed in d8a5361. |
danbev
added a commit
that referenced
this pull request
Jun 28, 2019
This commit removes the comment in cache_builder.cc regarding the usage of --code-cache-path with configure. Commit 14df42f ("build: run `mkcodecache` as an action") deprecated this option and it is always set to yes (unless cross compiling). PR-URL: #28419 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
This commit removes the comment in cache_builder.cc regarding the usage of --code-cache-path with configure. Commit 14df42f ("build: run `mkcodecache` as an action") deprecated this option and it is always set to yes (unless cross compiling). PR-URL: #28419 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
This commit removes the comment in cache_builder.cc regarding the usage of --code-cache-path with configure. Commit 14df42f ("build: run `mkcodecache` as an action") deprecated this option and it is always set to yes (unless cross compiling). PR-URL: #28419 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the comment in
cache_builder.ccregarding the usageof
--code-cache-pathwith configure.Commit 14df42f ("build: run
mkcodecacheas an action") deprecated this option and it is alwaysset to yes (unless cross compiling).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes