Skip to content

Layer5 added as a istio partner #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gunjanmimo
Copy link

Signed-off-by: gunjanmimo gunjan.mtbpaul@gmail.com

This pr is to add Layer5 as a partner of Istio

Signed-off-by: gunjanmimo <gunjan.mtbpaul@gmail.com>
@gunjanmimo gunjanmimo requested review from a team as code owners January 6, 2020 09:35
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Jan 6, 2020
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jan 6, 2020
@istio-testing
Copy link
Contributor

Hi @gunjanmimo. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn
Copy link
Contributor

ericvn commented Jan 6, 2020

This is the third PR I've reviewed asking to add Layer 5 to the partners page.

This one appears to be missing the assets/images/layer5/layer5-tag-community-white-bg.png and I'm not sure why the Chinese change is added. I'll make this one run the test so one can verify that the actual graphic works, bit one of the other 2 PRs had the correct graphic link. This on at least has the location of the partner correct.

This one also needs the CLA signed.

@ericvn
Copy link
Contributor

ericvn commented Jan 6, 2020

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 6, 2020
@istio-testing
Copy link
Contributor

@gunjanmimo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint_istio.io dafac60 link /test lint_istio.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu
Copy link
Collaborator

frankbu commented Jan 6, 2020

This is a duplicate of #6184.

@frankbu frankbu closed this Jan 6, 2020
@@ -1,5 +1,5 @@
---
title: Authentication
description: Controlling mutual TLS and end-user authentication for mesh services.
title: 认证
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't mix Chinese translation with other change in the same PR. Translation should be done in PRs with the translation/chinese label set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants