-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Layer5 added as a istio partner #6297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: gunjanmimo <gunjan.mtbpaul@gmail.com>
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Hi @gunjanmimo. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is the third PR I've reviewed asking to add Layer 5 to the partners page. This one appears to be missing the assets/images/layer5/layer5-tag-community-white-bg.png and I'm not sure why the Chinese change is added. I'll make this one run the test so one can verify that the actual graphic works, bit one of the other 2 PRs had the correct graphic link. This on at least has the location of the partner correct. This one also needs the CLA signed. |
/ok-to-test |
@gunjanmimo: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is a duplicate of #6184. |
@@ -1,5 +1,5 @@ | |||
--- | |||
title: Authentication | |||
description: Controlling mutual TLS and end-user authentication for mesh services. | |||
title: 认证 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't mix Chinese translation with other change in the same PR. Translation should be done in PRs with the translation/chinese
label set.
Signed-off-by: gunjanmimo gunjan.mtbpaul@gmail.com
This pr is to add Layer5 as a partner of Istio