added Layer5 #6184

ashiscs · 2019-12-23T12:13:36Z

To Add Layer5 logo to list of Istio partners on Istio.io

googlebot · 2019-12-23T12:13:41Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

istio-testing · 2019-12-23T12:13:52Z

Hi @ashiscs. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashiscs · 2019-12-23T12:19:01Z

@googlebot I signed it! and we'll verify it.

ericvn · 2019-12-31T16:07:25Z

content/en/about/community/partners/index.md

@@ -32,6 +32,7 @@ Istio benefits from an ecosystem of great partners. Check 'em out and learn how
    {{< company_logo link="https://www.tigera.io" logo="./tigera.svg" alt="Tigera" tagline="Zero Trust Network Security & Continuous Compliance for Kubernetes Platforms" >}}
    {{< company_logo link="https://www.vmware.com" logo="./vmware.svg" alt="VMware" >}}
    {{< company_logo link="https://wso2.com" logo="./wso2.svg" alt="WSO2" tagline="The #1 Open Source API Management and Integration Platform" >}}
+    {{< company_logo link="https://layer5.io/" logo="https://raw.githubusercontent.com/layer5io/layer5/master/assets/images/layer5/layer5-tag-community-white-bg.png" alt="Layer5" tagline="The Service Mesh Community - characterizing and contrasting service mesh projects and related technologies" >}}


This is similar to #6099

I notice the partners are listed in alphabetical order. To maintain that order, this would need to move up the list.

ericvn · 2019-12-31T16:07:43Z

/ok-to-test

ashiscs · 2019-12-31T16:24:40Z

@ericvn sir, what changes do I need to do?

ericvn · 2019-12-31T16:41:03Z

@ashiscs For the ordering, you would want to move what you added on line #35 to maybe line #25. Layer5 would be after Knative and before Pivotal.

You can see what the actual page looks like (I did this to check to logo) by selecting the Details link for the deploy/netlify test. This will bring up a site which includes your changes. Select About->Our Community->Partners links to get to the page. Right now, the Layer 5 logo is at the bottom right.

ericvn · 2019-12-31T16:44:49Z

@ashiscs Besides the change above, the CLA is still required. You might just need a single line with @googlebot I signed it! (Don't add the extra you had above, as the bot might just be picky).

ashiscs · 2019-12-31T16:49:31Z

@ericvn sir, so for adding CLA, I only need to add this single line (@googlebot I signed it!) ?

ericvn · 2019-12-31T17:31:28Z

@ashiscs Just the text inside the parends. I'm relatively new to this repo and the text appears to be different here than in the other repos. I'm just going by what the bot posted above, looking at the highlighted text. You posted the highlighted text plus some additional text that was in the bot post after the highlighted text.

ashiscs · 2020-01-01T19:10:10Z

@googlebot I signed it!

frankbu · 2020-01-02T15:56:56Z

@ashiscs Did you also actually sign the agreement? #6184 (comment)

ashiscs · 2020-01-02T15:58:45Z

@frankbu sir, yes i signed the agreement independently!

frankbu · 2020-01-02T16:16:05Z

Hmm, not sure why the CLA bot is still unhappy, but you also still need to move your new entry up in the list as @ericvn mentioned. #6184 (comment)

ashiscs · 2020-01-02T16:20:14Z

Will surely update that sir @frankbu .

ericvn · 2020-01-02T19:04:02Z

Not sure on the CLA bot either. Maybe it needs the `I consent'? similar to the other repos and the message hasn't been changed. Need to investigate the bot more.

frankbu · 2020-01-06T15:03:19Z

@ashiscs I'm still waiting for you to move the layer5 entry up in the list. I can merge this PR as soon as you do that.

ashiscs · 2020-01-06T15:49:26Z

@frankbu sir, sorry for the delay will do that by today!!

ashiscs · 2020-01-06T16:16:44Z

Done sir 0ff57aa

ashiscs · 2020-01-06T16:17:23Z

Ready for merging sir @frankbu !!

ashiscs · 2020-01-06T17:28:34Z

Thank you sir @frankbu .Done!!

ashiscs · 2020-01-06T17:52:13Z

@frankbu sir, ready for merging!!

howardjohn · 2020-01-07T16:37:39Z

The CLA is not signed. You may have signed it with a different email. It needs to be an email associated with your github account

ashiscs · 2020-01-07T18:40:39Z

@howardjohn sir, i signed it with the same email address which is associated with my github account.

howardjohn · 2020-01-07T18:48:09Z

@ashiscs please double check, the CLA is not signed correctly

ashiscs · 2020-01-07T18:56:25Z

@howardjohn sir, i double checked it and both the email address are same as well as CLA is correctly signed according to me!!

howardjohn · 2020-01-07T19:00:24Z

What is the email? You can send it to me on slack (same name) if that is preferred

…

On Tue, Jan 7, 2020 at 10:56 AM Ashis Kumar Singh ***@***.***> wrote: @howardjohn <https://github.com/howardjohn> sir, i double checked it and both the email address are same as well as CLA is correctly signed according to me!! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6184?email_source=notifications&email_token=AAEYGXPGCRS5UKAIZTHJL73Q4TF5VA5CNFSM4J6TPIX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJ4TEQ#issuecomment-571722130>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYGXPRSALC5MT2IRMMMU3Q4TF5VANCNFSM4J6TPIXQ> .

ashiscs · 2020-01-07T19:04:26Z

@howardjohn sir (ashissingh640@gmail.com)

howardjohn · 2020-01-07T19:15:31Z

You signed with github username=https://github.com/ashiscs, it should just be ashiscs

…

On Tue, Jan 7, 2020 at 11:04 AM Ashis Kumar Singh ***@***.***> wrote: @howardjohn <https://github.com/howardjohn> sir ***@***.***) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6184?email_source=notifications&email_token=AAEYGXIMT5LN3GR3MNRG563Q4TG3XA5CNFSM4J6TPIX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIJ5MKQ#issuecomment-571725354>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEYGXIDKDET5J3RD2XVOKTQ4TG3XANCNFSM4J6TPIXQ> .

ashiscs · 2020-01-07T19:29:32Z

@howardjohn sir, updated it now!!

ashiscs · 2020-01-07T19:57:21Z

/retest

frankbu · 2020-01-07T20:14:10Z

content/en/about/community/partners/index.md

@@ -23,6 +23,7 @@ Istio benefits from an ecosystem of great partners. Check 'em out and learn how
    {{< company_logo link="https://www.huaweicloud.com" logo="./huawei.png" alt="Huawei Cloud" >}}
    {{< company_logo link="https://www.ibm.com/cloud/" logo="./ibm-cloud.svg" alt="IBM Cloud" tagline="Built for all your applications. AI ready. Secure to the core." >}}
    {{< company_logo link="https://github.com/knative/docs" logo="./knative.png" alt="Knative" >}}
+    {{< company_logo link="https://layer5.io/" logo="https://raw.githubusercontent.com/layer5io/layer5/master/assets/images/layer5/layer5-tag-community-white-bg.png" alt="Layer5" tagline="The Service Mesh Community - characterizing and contrasting service mesh projects and related technologies" >}}


@ashiscs I just noticed one more thing that would be good to change before merging. Notice that all the other entries have a copy of the image in the current directory, instead of a full URL. Could you add a copy of the image in this PR and then change the entry to use it. Also the tagline is a little long. Since "The Service Mesh Community" is already part of the image, how about change like this?

Suggested change

{{< company_logo link="https://layer5.io/" logo="https://raw.githubusercontent.com/layer5io/layer5/master/assets/images/layer5/layer5-tag-community-white-bg.png" alt="Layer5" tagline="The Service Mesh Community - characterizing and contrasting service mesh projects and related technologies" >}}

{{< company_logo link="https://layer5.io/" logo="./layer5-tag-community-white-bg.png" alt="Layer5" tagline="Characterizing and contrasting service mesh projects and related technologies" >}}

frankbu

See inline comment.

googlebot · 2020-01-08T19:46:43Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

ashiscs · 2020-01-08T19:53:13Z

@frankbu sir, up for review??

ashiscs · 2020-01-08T20:15:50Z

@frankbu sir, can you check what kind of error it is giving i am not able to understand?

frankbu

@ashiscs the lint error is unrelated to your change and should be fixed soon.

frankbu · 2020-01-08T21:13:19Z

/test lint_istio.io

ashiscs · 2020-01-09T08:18:20Z

@frankbu sir, but still the logo is not showing on the partners page of istio??

frankbu · 2020-01-09T14:09:02Z

It's on the preliminary docs for the next Istio release (1.5) https://preliminary.istio.io/about/community/partners/

If you want it on the current istio.io web site, the PR needs to be cherry-picked to the release-1.4 branch.

frankbu · 2020-01-09T14:09:27Z

/cherrypick release-1.4

istio-testing · 2020-01-09T14:09:37Z

@frankbu: new pull request created: #6321

In response to this:

/cherrypick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

added Layer5

34274cb

ashiscs requested a review from a team as a code owner December 23, 2019 12:13

googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Dec 23, 2019

istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Dec 23, 2019

ericvn reviewed Dec 31, 2019

View reviewed changes

istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Dec 31, 2019

frankbu mentioned this pull request Jan 2, 2020

smmall changes #6099

Closed

frankbu mentioned this pull request Jan 6, 2020

Layer5 added as a istio partner #6297

Closed

added Layer5

0ff57aa

ashiscs requested a review from frankbu January 6, 2020 18:06

frankbu reviewed Jan 7, 2020

View reviewed changes

frankbu requested changes Jan 7, 2020

View reviewed changes

Add files via upload

6bda3a1

googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Jan 8, 2020

Done updation

6c705a5

ashiscs requested a review from frankbu January 8, 2020 19:51

frankbu approved these changes Jan 8, 2020

View reviewed changes

istio-testing merged commit 4d1d32c into istio:master Jan 8, 2020

istio-testing mentioned this pull request Jan 9, 2020

[release-1.4] added Layer5 #6321

Merged

	{{< company_logo link="https://layer5.io/" logo="https://raw.githubusercontent.com/layer5io/layer5/master/assets/images/layer5/layer5-tag-community-white-bg.png" alt="Layer5" tagline="The Service Mesh Community - characterizing and contrasting service mesh projects and related technologies" >}}
	{{< company_logo link="https://layer5.io/" logo="./layer5-tag-community-white-bg.png" alt="Layer5" tagline="Characterizing and contrasting service mesh projects and related technologies" >}}

added Layer5 #6184

added Layer5 #6184

Uh oh!

Conversation

ashiscs commented Dec 23, 2019

Uh oh!

googlebot commented Dec 23, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

istio-testing commented Dec 23, 2019

Uh oh!

ashiscs commented Dec 23, 2019 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericvn Dec 31, 2019

Choose a reason for hiding this comment

Uh oh!

ericvn commented Dec 31, 2019

Uh oh!

ashiscs commented Dec 31, 2019

Uh oh!

ericvn commented Dec 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericvn commented Dec 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashiscs commented Dec 31, 2019

Uh oh!

ericvn commented Dec 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ashiscs commented Jan 1, 2020

Uh oh!

frankbu commented Jan 2, 2020

Uh oh!

ashiscs commented Jan 2, 2020

Uh oh!

frankbu commented Jan 2, 2020

Uh oh!

ashiscs commented Jan 2, 2020

Uh oh!

ericvn commented Jan 2, 2020

Uh oh!

frankbu commented Jan 6, 2020

Uh oh!

ashiscs commented Jan 6, 2020

Uh oh!

ashiscs commented Jan 6, 2020

Uh oh!

ashiscs commented Jan 6, 2020

Uh oh!

ashiscs commented Jan 6, 2020

Uh oh!

ashiscs commented Jan 6, 2020

Uh oh!

howardjohn commented Jan 7, 2020

Uh oh!

ashiscs commented Jan 7, 2020

Uh oh!

howardjohn commented Jan 7, 2020

Uh oh!

ashiscs commented Jan 7, 2020

Uh oh!

howardjohn commented Jan 7, 2020 via email

Uh oh!

ashiscs commented Jan 7, 2020

Uh oh!

howardjohn commented Jan 7, 2020 via email

Uh oh!

ashiscs commented Jan 7, 2020

Uh oh!

ashiscs commented Jan 7, 2020

Uh oh!

frankbu Jan 7, 2020

Choose a reason for hiding this comment

Uh oh!

frankbu left a comment

ashiscs commented Dec 23, 2019 via email •

edited

Loading

ericvn commented Dec 31, 2019 •

edited

Loading

ericvn commented Dec 31, 2019 •

edited

Loading

ericvn commented Dec 31, 2019 •

edited

Loading