ext: notifications: Add link logging for management of new comments in Stdout #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkvach
force-pushed
the
fix/add-stdout-logging-for-new-comments
branch
from
1111fa8
to
eb26d9e
Compare
pkvach
force-pushed
the
fix/add-stdout-logging-for-new-comments
branch
from
eb26d9e
to
c9277c6
Compare
|
Tested locally and LGTM, is this ready for review or are you expecting to force-push something again? |
pkvach
force-pushed
the
fix/add-stdout-logging-for-new-comments
branch
from
c9277c6
to
1f6a96e
Compare
|
@ix5 |
|
Code LGTM. The thing that I'm stumbling over a bit is that this effectively gives anyone with log access (partial) admin rights. Then again, this can be guarded against by setting correct permissions on log files or Anyway, this PR is good to go, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
CHANGES.rstbecause this is a user-facing change or an important bugfixWhat changes does this Pull Request introduce?
When the server is configured with
general.notify = stdoutandmoderation.enabled = true, new comment activation links are not added to Stdout.I modified the Stdout class to log a direct link to a new comment, as well as links to delete or activate the comment.
Why is this necessary?
Fixes #138