Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activation link is not written to stdout #138

Closed
mbrgm opened this issue Nov 16, 2014 · 1 comment · Fixed by #1016
Closed

Activation link is not written to stdout #138

mbrgm opened this issue Nov 16, 2014 · 1 comment · Fixed by #1016
Labels
bug needs-contributor Someone needs to implement this. Help wanted! server (Python) server code
Milestone

Comments

@mbrgm
Copy link

mbrgm commented Nov 16, 2014

The docs say

The moderation is done with signed URLs sent by email or logged to stdout.

I have my server configured with general.notify = stdout and moderation.enabled = true. Comments are properly held back from the view until they're activated, but I could find no links in the logs.

I inspected the Stdout class and could find no hint of the activation link been written to stdout as well. For SMTP, uwsgi.spool is called with a formatted message body, but for Stdout, just the json data is written.

I think logging the activation link to stdout is not nearly as practical as sending via SMTP, but then the docs would have to be changed accordingly.

@posativ posativ modified the milestones: 0.10, 1.0 Nov 25, 2014
@posativ
Copy link
Collaborator

posativ commented Nov 25, 2014

You're right, this is a regression but I won't fix it for now. The extension module is not well written and needs an overhaul in general.

@ix5 ix5 added bug needs-contributor Someone needs to implement this. Help wanted! server (Python) server code labels Feb 10, 2022
@ix5 ix5 modified the milestones: 1.0, backburner Feb 24, 2022
pkvach added a commit to pkvach/isso that referenced this issue Apr 23, 2024
pkvach added a commit to pkvach/isso that referenced this issue Apr 23, 2024
pkvach added a commit to pkvach/isso that referenced this issue Apr 23, 2024
pkvach added a commit to pkvach/isso that referenced this issue Apr 24, 2024
ix5 pushed a commit to ix5/isso that referenced this issue Apr 29, 2024
@ix5 ix5 closed this as completed in #1016 Apr 29, 2024
mgc8 pushed a commit to mgc8/isso that referenced this issue Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-contributor Someone needs to implement this. Help wanted! server (Python) server code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants